Revisit MCP ObjectMapper config #4791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 132d50b. Signed-off-by: Eric Bottard <[email protected]>
…nfiguration" This reverts commit fdf21f4. Signed-off-by: Eric Bottard <[email protected]>
Adjust tests Closes spring-projects#4730 Signed-off-by: Eric Bottard <[email protected]>
There was a problem hiding this comment.
Should org.springframework.ai.mcp.server.common.autoconfigure.McpServerObjectMapperAutoConfiguration be added here to make sure the order is more explicit (though it will be implicitly driven by the dependency bean defined).
There was a problem hiding this comment.
Until proven otherwise, this is not necessary, so I'll abstain. Moreover, it would also apply to other AutoConfig that also use a bean defined by the new AutoConfig this PR introduces.
I'll continue doing some research on what is and isn't necessary, but I think if you're ok with the rest of this PR, it can be merged as is.
ilayaperumalg
approved these changes
Nov 4, 2025
|
Rebased, squashed and merged as 6d9b8e6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resurrecting PR #4730, with the added trick of
@Bean(defaultCandidate=false)